Message 198235 - Python tracker

Message198235

Author	terry.reedy
Recipients	Arfrever, chortos, gvanrossum, petri.lehtinen, pitrou, python-dev, r.david.murray, serhiy.storchaka, terry.reedy, vstinner
Date	2013-09-22.00:05:16
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1379808316.42.0.374837323115.issue12085@psf.upfronthosting.co.za>
In-reply-to

Content
Right. If _internal_poll raises, it should not be masked as that would be a true bug. More research. 'self.returncode = None' comes before the only call to the appropriate posix/windows version of ._execute_child(), which is the only place where '_child_created = True'. So class level _child_created = False # needed for __del__ if __init__ call fails should be sufficient. With that added, self._child_created = False in __init__ would not be really needed. As I said on pydev, making the warning a Warning would be a different issue.

Content

Right. If _internal_poll raises, it should not be masked as that would be a true bug.

More research. 'self.returncode = None' comes before the only call to the appropriate posix/windows version of ._execute_child(), which is the only place where '_child_created = True'. So class level
    _child_created = False  # needed for __del__ if __init__ call fails
should be sufficient. With that added,
        self._child_created = False
in __init__ would not be really needed. 

As I said on pydev, making the warning a Warning would be a different issue.

History
Date	User	Action	Args
2013-09-22 00:05:16	terry.reedy	set	recipients: + terry.reedy, gvanrossum, pitrou, vstinner, Arfrever, r.david.murray, chortos, python-dev, petri.lehtinen, serhiy.storchaka
2013-09-22 00:05:16	terry.reedy	set	messageid: <1379808316.42.0.374837323115.issue12085@psf.upfronthosting.co.za>
2013-09-22 00:05:16	terry.reedy	link	issue12085 messages
2013-09-22 00:05:16	terry.reedy	create