Home Original page

Message 200383 - Python tracker

Message200383

Author Arfrever
Recipients Arfrever, eric.araujo, georg.brandl, jwilk, jyasskin, koobs, lambacck, lemburg, loewis, lukasz.langa, marienz, mark.dickinson, ned.deily, nyogtha, pitrou, ronaldoussoren, rpetrov, skrah, tarek, vaxhacker
Date 2013-10-19.07:33:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1382167989.38.0.650653258444.issue969718@psf.upfronthosting.co.za>
In-reply-to
Content 
OPT should not be used in Distutils at all.

Lib/distutils/sysconfig.py should have:
    if 'CFLAGS' in os.environ:
        cflags = os.environ['CFLAGS']

Makefile.pre.in should have:
    $(RUNSHARED) CC='$(CC)' LDSHARED='$(BLDSHARED)' CFLAGS='$(PY_CFLAGS)' \
    _TCLTK_INCLUDES='$(TCLTK_INCLUDES)' _TCLTK_LIBS='$(TCLTK_LIBS)' \
    $(PYTHON_FOR_BUILD) $(srcdir)/setup.py $$quiet build

PY_CFLAGS is defined as:
PY_CFLAGS=      $(BASECFLAGS) $(OPT) $(CONFIGURE_CFLAGS) $(CFLAGS) $(EXTRA_CFLAGS)

So then OPT could be overriden when calling `make`.

See my patch for Distutils in bug #1222585. That patch also cleans handling of flags.
History
Date User Action Args
2013-10-19 07:33:09Arfreversetrecipients: + Arfrever, lemburg, loewis, georg.brandl, ronaldoussoren, mark.dickinson, vaxhacker, nyogtha, marienz, pitrou, jyasskin, tarek, jwilk, ned.deily, eric.araujo, rpetrov, lambacck, skrah, lukasz.langa, koobs
2013-10-19 07:33:09Arfreversetmessageid: <1382167989.38.0.650653258444.issue969718@psf.upfronthosting.co.za>
2013-10-19 07:33:09Arfreverlinkissue969718 messages
2013-10-19 07:33:09Arfrevercreate