Message201572
| Author | gvanrossum |
|---|---|
| Recipients | daniel.urban, grahamd, gvanrossum, pitrou, rhettinger |
| Date | 2013-10-28.19:25:39 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1382988340.14.0.769343191256.issue19072@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
@grahamd: I occasionally have felt the pain of wrapping @classmethod (or @staticmethod). Never enough though to think of how to fix it. I really don't have the stomach to review your wrapt library, but your code looks okay except for style and missing tests. I'd also recommend adding a few words to the docs. (And yes, all of this is your responsibility -- nobody has time to do all that stuff for you.)
Style-wise:
- the continuation line in your patch is not properly formatted;
- either the else block should also use { } or the else clause should be omitted. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2013-10-28 19:25:40 | gvanrossum | set | recipients: + gvanrossum, rhettinger, pitrou, grahamd, daniel.urban |
| 2013-10-28 19:25:40 | gvanrossum | set | messageid: <1382988340.14.0.769343191256.issue19072@psf.upfronthosting.co.za> |
| 2013-10-28 19:25:40 | gvanrossum | link | issue19072 messages |
| 2013-10-28 19:25:39 | gvanrossum | create | |