Message 202269 - Python tracker

Message202269

Author	vstinner
Recipients	Ramchandra Apte, belopolsky, flox, gladman, patrick.vrijlandt, tim.golden, vstinner
Date	2013-11-06.15:23:14
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1383751394.62.0.474557070523.issue13674@psf.upfronthosting.co.za>
In-reply-to

Content
+ if (strchr("y", outbuf[1]) && buf.tm_year < 0) hum... why not simply outbuf[1] == 'y' ? It would be more explicit and less surprising. For the unit test, it would be nice to test also asctime(), even if time.asctime() doesn't use asctime() of the C library. And it's better to run tests on all platforms. Only test_y_before_1900() should behave differently on other platforms, but it would be nice to run test_y_before_1900() on platforms supporting "%y" with year < 1900. In my experience, other operating systems have also their own issues. For example, time.strftime() has a specific test to Windows, but also Solaris and AIX.

Content

+        if (strchr("y", outbuf[1]) && buf.tm_year < 0)

hum... why not simply outbuf[1] == 'y' ? It would be more explicit and less surprising.

For the unit test, it would be nice to test also asctime(), even if time.asctime() doesn't use asctime() of the C library. And it's better to run tests on all platforms. Only test_y_before_1900() should behave differently on other platforms, but it would be nice to run test_y_before_1900() on platforms supporting "%y" with year < 1900. In my experience, other operating systems have also their own issues. For example, time.strftime() has a specific test to Windows, but also Solaris and AIX.

History
Date	User	Action	Args
2013-11-06 15:23:14	vstinner	set	recipients: + vstinner, belopolsky, tim.golden, flox, patrick.vrijlandt, Ramchandra Apte, gladman
2013-11-06 15:23:14	vstinner	set	messageid: <1383751394.62.0.474557070523.issue13674@psf.upfronthosting.co.za>
2013-11-06 15:23:14	vstinner	link	issue13674 messages
2013-11-06 15:23:14	vstinner	create