Message 206793 - Python tracker

Message206793

Author	BreamoreBoy
Recipients	BreamoreBoy, ezio.melotti, georg.brandl, loewis, mark.dickinson, pitrou, serhiy.storchaka, terry.reedy
Date	2013-12-21.22:38:39
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1387665519.28.0.280511084174.issue20047@psf.upfronthosting.co.za>
In-reply-to

Content
I believe that all methods should act the same, but they don't as a result of the work done in issue12170. E.g. find will accept integer input but split will not. Given this comment at the top of test_bytes.py "XXX This is a mess. Common tests should be moved to buffer_tests.py, which itself ought to be unified with string_tests.py (and the latter should be modernized).", it looks like a thorough review of the code and tests is in order.

Content

I believe that all methods should act the same, but they don't as a result of the work done in issue12170.  E.g. find will accept integer input but split will not.  Given this comment at the top of test_bytes.py "XXX This is a mess.  Common tests should be moved to buffer_tests.py, which itself ought to be unified with string_tests.py (and the latter should be modernized).", it looks like a thorough review of the code and tests is in order.

History
Date	User	Action	Args
2013-12-21 22:38:39	BreamoreBoy	set	recipients: + BreamoreBoy, loewis, georg.brandl, terry.reedy, mark.dickinson, pitrou, ezio.melotti, serhiy.storchaka
2013-12-21 22:38:39	BreamoreBoy	set	messageid: <1387665519.28.0.280511084174.issue20047@psf.upfronthosting.co.za>
2013-12-21 22:38:39	BreamoreBoy	link	issue20047 messages
2013-12-21 22:38:39	BreamoreBoy	create