Message 216285 - Python tracker

Message216285

Author	benjamin.peterson
Recipients	Dima.Tisnek, benjamin.peterson, python-dev
Date	2014-04-15.12:58:39
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1397566716.29084.106706669.56C920D2@webmail.messagingengine.com>
In-reply-to	<1397554457.58.0.99289799944.issue21191@psf.upfronthosting.co.za>

Content
On Tue, Apr 15, 2014, at 2:34, Dima Tisnek wrote: > > Dima Tisnek added the comment: > > Banjamin, Your patch looks good to me! > > I have a small concern regarding "We now know we will succeed..." -- > should there be a test case to make sure fstat test here matches whatever > test is/was done on a lower level? > > Or is your code now such that it will explicitly succeed because it > doesn't call anything that can fail after the comment? That's what I mean.

Content

On Tue, Apr 15, 2014, at 2:34, Dima Tisnek wrote:
> 
> Dima Tisnek added the comment:
> 
> Banjamin, Your patch looks good to me!
> 
> I have a small concern regarding "We now know we will succeed..." --
> should there be a test case to make sure fstat test here matches whatever
> test is/was done on a lower level?
> 
> Or is your code now such that it will explicitly succeed because it
> doesn't call anything that can fail after the comment?

That's what I mean.

History
Date	User	Action	Args
2014-04-15 12:58:39	benjamin.peterson	set	recipients: + benjamin.peterson, python-dev, Dima.Tisnek
2014-04-15 12:58:39	benjamin.peterson	link	issue21191 messages
2014-04-15 12:58:39	benjamin.peterson	create