Message218031
| Author | ned.deily |
|---|---|
| Recipients | doko, eric.araujo, hynek, ned.deily, ronaldoussoren, twouters |
| Date | 2014-05-07.01:12:11 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1399425131.99.0.348234920461.issue17752@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
The quotes that you removed around the DYLD_FRAMEWORK_PATH step are not needed, at least until the rest of configure.ac and Makefile.pre.in support paths with spaces et al. However, you missed removing the single quotes around the DYLD_LIBRARY_PATH step here:
RUNSHARED='DYLD_LIBRARY_PATH=`pwd`${DYLD_LIBRARY_PATH:+:${DYLD_LIBRARY_PATH}}'
Otherwise, the patch LGTM; I tested it with --enable-framework and --enable-shared configs on OS X. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2014-05-07 01:12:12 | ned.deily | set | recipients: + ned.deily, twouters, doko, ronaldoussoren, eric.araujo, hynek |
| 2014-05-07 01:12:11 | ned.deily | set | messageid: <1399425131.99.0.348234920461.issue17752@psf.upfronthosting.co.za> |
| 2014-05-07 01:12:11 | ned.deily | link | issue17752 messages |
| 2014-05-07 01:12:11 | ned.deily | create | |