Message220391
| Author | taleinat |
|---|---|
| Recipients | BreamoreBoy, George.Dhoore, Saimadhav.Heblikar, asvetlov, ned.deily, roger.serwy, taleinat, terry.reedy |
| Date | 2014-06-12.21:49:36 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1402609776.46.0.182922557896.issue11437@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
I don't think the patch should currently be committed. I agree with Terry: we should first fix the issue whereby the key config is read repeatedly. Given such a fix, the problematic "known_invalid" workaround in the patch would no longer be necessary. As a side note, I think the method used in the patch to check if a binding is good. Ideally it would be the final check done after a simpler syntax check, since a syntax check could give more informative error messages. Also, there are two other more technical issues with the patch; I mentioned them in the patch review system. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2014-06-12 21:49:36 | taleinat | set | recipients: + taleinat, terry.reedy, ned.deily, roger.serwy, asvetlov, BreamoreBoy, George.Dhoore, Saimadhav.Heblikar |
| 2014-06-12 21:49:36 | taleinat | set | messageid: <1402609776.46.0.182922557896.issue11437@psf.upfronthosting.co.za> |
| 2014-06-12 21:49:36 | taleinat | link | issue11437 messages |
| 2014-06-12 21:49:36 | taleinat | create | |