Message 229520 - Python tracker

Message229520

Author	vstinner
Recipients	Arfrever, vstinner
Date	2014-10-16.10:16:52
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1413454614.52.0.959584041085.issue22636@psf.upfronthosting.co.za>
In-reply-to

Content
Updated patch which address also BSD and Solaris systems. I also changed the behaviour when a required command is missing: return None instead of raising an OSError. In the current code, when a command is missing, the shell scripts return the exit code 10. The Python codes checks for the exit code 10, but in fact os.popen() returns a status, not directly the exit code. So the OSError was never raised. I don't know if it's better to return None instead of raising an error? It changes the behaviour, can it break backward compatibility?

Content

Updated patch which address also BSD and Solaris systems.

I also changed the behaviour when a required command is missing: return None instead of raising an OSError.

In the current code, when a command is missing, the shell scripts return the exit code 10. The Python codes checks for the exit code 10, but in fact os.popen() returns a status, not directly the exit code. So the OSError was never raised.

I don't know if it's better to return None instead of raising an error? It changes the behaviour, can it break backward compatibility?

History
Date	User	Action	Args
2014-10-16 10:16:54	vstinner	set	recipients: + vstinner, Arfrever
2014-10-16 10:16:54	vstinner	set	messageid: <1413454614.52.0.959584041085.issue22636@psf.upfronthosting.co.za>
2014-10-16 10:16:54	vstinner	link	issue22636 messages
2014-10-16 10:16:54	vstinner	create