Message234408
| Author | NeilGirdhar |
|---|---|
| Recipients | Jeff.Kaufman, Joshua.Landau, NeilGirdhar, Rosuav, SpaghettiToastBook, andybuckley, belopolsky, berker.peksag, eric.araujo, eric.snow, ezio.melotti, georg.brandl, giampaolo.rodola, gvanrossum, ncoghlan, paul.moore, pconnell, r.david.murray, terry.reedy, twouters, zbysz |
| Date | 2015-01-20.23:40:59 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1421797260.46.0.549401805709.issue2292@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
Thanks!
I've incorporated your changes to deal with the [*[0] for i in [0]] problem, although I don't understand them yet.
The problem with using STORE_MAP is you create a new dict for each keyword argument in that situation. I optimized that away. Good catch on the BUILD_MAP opcode problem. I could not figure out why that wasn't working!
I added some tests. Did you say you had some tests?
One of the tests that both of our code is failing on still is:
>>> def f(x, y):
... print(x, y)
...
>>> f(x=5, **{'x': 1}, **{'x': 3}, y=2)
It's just a problem in ceval that I'll work on now. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2015-01-20 23:41:03 | NeilGirdhar | set | recipients: + NeilGirdhar, gvanrossum, twouters, georg.brandl, terry.reedy, paul.moore, ncoghlan, belopolsky, giampaolo.rodola, ezio.melotti, eric.araujo, andybuckley, r.david.murray, zbysz, eric.snow, Rosuav, berker.peksag, Joshua.Landau, pconnell, Jeff.Kaufman, SpaghettiToastBook |
| 2015-01-20 23:41:00 | NeilGirdhar | set | messageid: <1421797260.46.0.549401805709.issue2292@psf.upfronthosting.co.za> |
| 2015-01-20 23:41:00 | NeilGirdhar | link | issue2292 messages |
| 2015-01-20 23:41:00 | NeilGirdhar | create | |