Message 234457 - Python tracker

Message234457

Author	NeilGirdhar
Recipients	Jeff.Kaufman, Joshua.Landau, NeilGirdhar, Rosuav, SpaghettiToastBook, andybuckley, belopolsky, berker.peksag, eric.araujo, eric.snow, ezio.melotti, georg.brandl, giampaolo.rodola, gvanrossum, ncoghlan, paul.moore, pconnell, r.david.murray, terry.reedy, twouters, zbysz
Date	2015-01-22.00:01:43
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1421884903.16.0.806150639083.issue2292@psf.upfronthosting.co.za>
In-reply-to

Content
Very nice! So what's left besides errors? * Fixing the grammar, ast, and compilation for the list, dict, and set comprehension element unpackings > Now the primary problem is giving good errors; I don't know how to make them look like they came from the function call. I'm not sure I want to, either, since these opcodes are used elsewhere. The _UNPACK opcodes are new in this changelist. You can do "hg vdiff" to give a side-by-side diff or just check in the patch review.

Content

Very nice!  So what's left besides errors?

* Fixing the grammar, ast, and compilation for the list, dict, and set comprehension element unpackings

> Now the primary problem is giving good errors; I don't know how to make them look like they came from the function call. I'm not sure I want to, either, since these opcodes are used elsewhere.

The _UNPACK opcodes are new in this changelist.  You can do "hg vdiff" to give a side-by-side diff or just check in the patch review.

History
Date	User	Action	Args
2015-01-22 00:01:43	NeilGirdhar	set	recipients: + NeilGirdhar, gvanrossum, twouters, georg.brandl, terry.reedy, paul.moore, ncoghlan, belopolsky, giampaolo.rodola, ezio.melotti, eric.araujo, andybuckley, r.david.murray, zbysz, eric.snow, Rosuav, berker.peksag, Joshua.Landau, pconnell, Jeff.Kaufman, SpaghettiToastBook
2015-01-22 00:01:43	NeilGirdhar	set	messageid: <1421884903.16.0.806150639083.issue2292@psf.upfronthosting.co.za>
2015-01-22 00:01:43	NeilGirdhar	link	issue2292 messages
2015-01-22 00:01:43	NeilGirdhar	create