Message235244
| Author | skrah |
|---|---|
| Recipients | larry, skrah |
| Date | 2015-02-02.12:17:17 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1422879437.88.0.730176140595.issue23376@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
The call to PyBuffer_IsContiguous() (see patch) is redundant: PyBUF_WRITABLE is a flag that can be added to any buffer request. The real request here is (PyBUF_SIMPLE|PyBUF_WRITABLE), which is equal to PyBUF_WRITABLE since PyBUF_SIMPLE==0. PyBUF_SIMPLE implies C-contiguous with format 'B'. Perhaps the check was added for broken buffer providers, but I think at some point we should assume correct providers. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2015-02-02 12:17:17 | skrah | set | recipients: + skrah, larry |
| 2015-02-02 12:17:17 | skrah | set | messageid: <1422879437.88.0.730176140595.issue23376@psf.upfronthosting.co.za> |
| 2015-02-02 12:17:17 | skrah | link | issue23376 messages |
| 2015-02-02 12:17:17 | skrah | create | |