Message235459
| Author | giampaolo.rodola |
|---|---|
| Recipients | christian.heimes, felipecruz, giampaolo.rodola, gvanrossum, meador.inge, neologix, pitrou, python-dev, rosslagerwall, sbt, vstinner, yselivanov |
| Date | 2015-02-06.03:05:42 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1423191942.76.0.565497477442.issue18932@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
Yes, it appears so. I would suggest to come up with a patch which overrides modify() for all those selectors which can benefit from it (poll, epoll, kqueue) and refactor register() / unregister() (for select) in a separate issue / patch. Also, I suppose a couple of tests should be added (if not there already) in order to make sure that 'events' and 'data' arguments get actually changed in different situations. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2015-02-06 03:05:42 | giampaolo.rodola | set | recipients: + giampaolo.rodola, gvanrossum, pitrou, vstinner, christian.heimes, meador.inge, neologix, rosslagerwall, python-dev, sbt, felipecruz, yselivanov |
| 2015-02-06 03:05:42 | giampaolo.rodola | set | messageid: <1423191942.76.0.565497477442.issue18932@psf.upfronthosting.co.za> |
| 2015-02-06 03:05:42 | giampaolo.rodola | link | issue18932 messages |
| 2015-02-06 03:05:42 | giampaolo.rodola | create | |