Message 235533 - Python tracker

Message235533

Author	eryksun
Recipients	craigh, eryksun, steve.dower, tim.golden, zach.ware
Date	2015-02-07.23:36:37
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1423352197.62.0.262781162113.issue23407@psf.upfronthosting.co.za>
In-reply-to

Content
To check for a link on Windows, os.walk calls ntpath.islink, which calls os.lstat. Currently the os.lstat implementation only sets S_IFLNK for symbolic links. attribute_data_to_stat could also check for junctions (IO_REPARSE_TAG_MOUNT_POINT). For consistency, os.readlink should also read junctions (rdb->MountPointReparseBuffer). islink https://hg.python.org/cpython/file/7b493dbf944b/Lib/ntpath.py#l239 attribute_data_to_stat https://hg.python.org/cpython/file/7b493dbf944b/Modules/posixmodule.c#l1515 win_readlink https://hg.python.org/cpython/file/7b493dbf944b/Modules/posixmodule.c#l10056 REPARSE_DATA_BUFFER https://hg.python.org/cpython/file/7b493dbf944b/Modules/winreparse.h#l11

Content

To check for a link on Windows, os.walk calls ntpath.islink, which calls os.lstat. Currently the os.lstat implementation only sets S_IFLNK for symbolic links. attribute_data_to_stat could also check for junctions (IO_REPARSE_TAG_MOUNT_POINT). For consistency, os.readlink should also read junctions (rdb->MountPointReparseBuffer).

islink
https://hg.python.org/cpython/file/7b493dbf944b/Lib/ntpath.py#l239

attribute_data_to_stat
https://hg.python.org/cpython/file/7b493dbf944b/Modules/posixmodule.c#l1515

win_readlink
https://hg.python.org/cpython/file/7b493dbf944b/Modules/posixmodule.c#l10056

REPARSE_DATA_BUFFER
https://hg.python.org/cpython/file/7b493dbf944b/Modules/winreparse.h#l11

History
Date	User	Action	Args
2015-02-07 23:36:37	eryksun	set	recipients: + eryksun, tim.golden, craigh, zach.ware, steve.dower
2015-02-07 23:36:37	eryksun	set	messageid: <1423352197.62.0.262781162113.issue23407@psf.upfronthosting.co.za>
2015-02-07 23:36:37	eryksun	link	issue23407 messages
2015-02-07 23:36:37	eryksun	create