Message236990
| Author | serhiy.storchaka |
|---|---|
| Recipients | gvanrossum, orsenthil, serhiy.storchaka, vstinner, yselivanov |
| Date | 2015-03-01.22:09:08 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1425247749.12.0.326522997426.issue20271@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
splitport() shouldn't handle auth, it should be called after auth is dropped with splituser().
The patch makes URL parsing slower, especially URLs with IPv6 addresses.
$ ./python -m timeit -s "from urllib.parse import urlparse, clear_cache" -- "urlparse('http://python.org:80'); clear_cache()"
Unpatched: 10000 loops, best of 3: 70.3 usec per loop
Patched: 10000 loops, best of 3: 105 usec per loop
$ ./python -m timeit -s "from urllib.parse import urlparse, clear_cache" -- "urlparse('http://[2001:4802:7901:0:e60a:1375:0:5]:80'); clear_cache()"
Unpatched: 10000 loops, best of 3: 71.1 usec per loop
Patched: 1000 loops, best of 3: 239 usec per loop |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2015-03-01 22:09:09 | serhiy.storchaka | set | recipients: + serhiy.storchaka, gvanrossum, orsenthil, vstinner, yselivanov |
| 2015-03-01 22:09:09 | serhiy.storchaka | set | messageid: <1425247749.12.0.326522997426.issue20271@psf.upfronthosting.co.za> |
| 2015-03-01 22:09:09 | serhiy.storchaka | link | issue20271 messages |
| 2015-03-01 22:09:08 | serhiy.storchaka | create | |