Message239667
| Author | serhiy.storchaka |
|---|---|
| Recipients | abacabadabacaba, berker.peksag, ethan.furman, larry, mark.dickinson, python-dev, rhettinger, serhiy.storchaka |
| Date | 2015-03-31.05:28:50 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1934848.ON4Xrs2XsK@raxxla> |
| In-reply-to | <1427768343.98.0.623073073319.issue22609@psf.upfronthosting.co.za> |
| Content | |
|---|---|
Thank you for your review Berker. > Is there a reason not to use assertWarnsRegex? Initially the patch was written for 2.7. Fixing WeakValueDictionary in 2.7 needs first fix UserDict (issue22958). That is why I returned to this issue. > Also, there are already collections.UserDict() usages in the test file, so > I'd remove the "from collections import UserDict" import. These tests originally was written for test_collections. Updated patch addresses Berker's comment. |
|
| Files | |
|---|---|
| File name | Uploaded |
| UserDict_self_and_dict_keywords_2.patch | serhiy.storchaka, 2015-03-31.05:28:50 |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2015-03-31 05:28:51 | serhiy.storchaka | set | recipients: + serhiy.storchaka, rhettinger, mark.dickinson, larry, abacabadabacaba, ethan.furman, python-dev, berker.peksag |
| 2015-03-31 05:28:50 | serhiy.storchaka | link | issue22609 messages |
| 2015-03-31 05:28:50 | serhiy.storchaka | create | |