> I'm thinking also, maybe instead of putting script_helper into the
> test.support namespace, we could move the individual methods and
> helpers from script_helper into test.support, e.g.:
>
> test.support.run_python_until_end
> vs.
> test.support.script_helper.run_python_until_end1
Yes, I also agree that this looks better.
But as this was first humble patch submission to CPython, I followed David Murry's instructions during my review - which was to move the entire module.
I would be opposed to adding the methods directly into __init__.py,
I would recommend still moving script_helper into test.support , and adding a list of symbols from script_helper.py into __init__
eg:
test/support/__init__.py:
from script_helper import run_python_until_end
test/some_test.py:
from test.support import run_python_until_end
I am currently in the PyCon CPython sprint room if you are also here. |