Message242785
| Author | ncoghlan |
|---|---|
| Recipients | NeilGirdhar, Rosuav, belopolsky, berker.peksag, ethan.furman, gvanrossum, ncoghlan, python-dev, r.david.murray, rhettinger, schlamar, scoder, serhiy.storchaka, vstinner, yselivanov |
| Date | 2015-05-08.23:13:26 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <CADiSq7dQwUmi1Q6ib-uu9oYobb2UfyBhz7wDmRQd75rdvNJv7A@mail.gmail.com> |
| In-reply-to | <1431099215.29.0.488348354661.issue22906@psf.upfronthosting.co.za> |
| Content | |
|---|---|
Latest patch LGTM, although I believe the new chaining behaviour checks would be clearer with the 3 try/except blocks merged into a single block where all 3 behaviours are checked in the same except clause, and the else clause complains that StopIteration was suppressed. (I don't see a need to request a new review for that particular change, though) |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2015-05-08 23:13:26 | ncoghlan | set | recipients: + ncoghlan, gvanrossum, rhettinger, belopolsky, scoder, vstinner, r.david.murray, ethan.furman, python-dev, schlamar, Rosuav, berker.peksag, serhiy.storchaka, yselivanov, NeilGirdhar |
| 2015-05-08 23:13:26 | ncoghlan | link | issue22906 messages |
| 2015-05-08 23:13:26 | ncoghlan | create | |