Message243479
| Author | skrah |
|---|---|
| Recipients | barry, ethan.furman, lemburg, petr.viktorin, rhettinger, serhiy.storchaka, skrah |
| Date | 2015-05-18.13:46:09 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1431956769.79.0.255704514668.issue23699@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
The problem with this macro is that most of the time it takes the
standard cmp return value {-1,0,1} and converts that into a bool.
For this use case, it might be more appropriate to use a
static inline function Py_cmp_to_bool().
To put it differently, the macro mostly does not perform the
actual rich comparison but just post-processes the result.
I don't like the dual use of converting cmp() return values
and performing actual comparisons on integers, so -1 on
the concept. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2015-05-18 13:46:09 | skrah | set | recipients: + skrah, lemburg, barry, rhettinger, petr.viktorin, ethan.furman, serhiy.storchaka |
| 2015-05-18 13:46:09 | skrah | set | messageid: <1431956769.79.0.255704514668.issue23699@psf.upfronthosting.co.za> |
| 2015-05-18 13:46:09 | skrah | link | issue23699 messages |
| 2015-05-18 13:46:09 | skrah | create | |