Message243811
| Author | ncoghlan |
|---|---|
| Recipients | gvanrossum, ncoghlan, yselivanov |
| Date | 2015-05-22.06:46:56 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1432277216.64.0.164257319827.issue24237@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
The patch mostly looks good to me, but I suggest using "test.support.check_warnings" for the cases where you're checking that the warning is raised as expected: https://docs.python.org/3/library/test.html#test.support.check_warnings It's slightly simpler than constructing the same logic yourself using warnings.catch_warnings. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2015-05-22 06:46:56 | ncoghlan | set | recipients: + ncoghlan, gvanrossum, yselivanov |
| 2015-05-22 06:46:56 | ncoghlan | set | messageid: <1432277216.64.0.164257319827.issue24237@psf.upfronthosting.co.za> |
| 2015-05-22 06:46:56 | ncoghlan | link | issue24237 messages |
| 2015-05-22 06:46:56 | ncoghlan | create | |