Message260448
| Author | martin.panter |
|---|---|
| Recipients | bwmcadams, christian.heimes, cjw296, deronnax, dieresys, georg.brandl, jjlee, kristjan.jonsson, martin.panter, orsenthil, r.david.murray, santoso.wijaya |
| Date | 2016-02-18.10:57:46 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1455793067.12.0.866037114584.issue2202@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
I do wonder if NotImplementedError is the right exception. According to the documentation it is derived from RuntimeError and is meant for abstract methods, i.e. it is a programmer error. Other cases in urllib.request raise ValueError (e.g. AbstractBasicAuthHandler), which is fairly normal for protocol errors like this. Also it would be nice to add a test case for the bug fix. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2016-02-18 10:57:47 | martin.panter | set | recipients: + martin.panter, georg.brandl, jjlee, orsenthil, kristjan.jonsson, christian.heimes, cjw296, bwmcadams, dieresys, r.david.murray, santoso.wijaya, deronnax |
| 2016-02-18 10:57:47 | martin.panter | set | messageid: <1455793067.12.0.866037114584.issue2202@psf.upfronthosting.co.za> |
| 2016-02-18 10:57:47 | martin.panter | link | issue2202 messages |
| 2016-02-18 10:57:46 | martin.panter | create | |