Message 260940 - Python tracker

Message260940

Author	eric.fahlgren
Recipients	Barun Parruck, eric.fahlgren, llllllllll
Date	2016-02-27.14:02:37
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1456581758.89.0.193658013835.issue26448@psf.upfronthosting.co.za>
In-reply-to

Content
Lookin' good so far. How about we try it on all the opcodes that have arguments? See attached example for which I can see two obvious improvements: 1) It could be improved by taking apart that "args" list and using it to synthesize "sample_code" rather than having to hand duplicate the values in two places, albeit with different byte order. 2) Likewise, my hard-coded "offsets" table is pretty awful. :) Also, is there already a test for the dis module in which you could just add this as a case?

Content

Lookin' good so far.  How about we try it on all the opcodes that have arguments?

See attached example for which I can see two obvious improvements:
1) It could be improved by taking apart that "args" list and using it to synthesize "sample_code" rather than having to hand duplicate the values in two places, albeit with different byte order.
2) Likewise, my hard-coded "offsets" table is pretty awful. :)

Also, is there already a test for the dis module in which you could just add this as a case?

History
Date	User	Action	Args
2016-02-27 14:02:38	eric.fahlgren	set	recipients: + eric.fahlgren, llllllllll, Barun Parruck
2016-02-27 14:02:38	eric.fahlgren	set	messageid: <1456581758.89.0.193658013835.issue26448@psf.upfronthosting.co.za>
2016-02-27 14:02:38	eric.fahlgren	link	issue26448 messages
2016-02-27 14:02:38	eric.fahlgren	create