Message 267609 - Python tracker

Message267609

Author	vstinner
Recipients	Colm Buckley, doko, larry, lemburg, martin.panter, matejcik, ned.deily, python-dev, rhettinger, skrah, thomas-petazzoni, vstinner, ztane
Date	2016-06-07.09:39:57
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1465292397.35.0.254476882747.issue26839@psf.upfronthosting.co.za>
In-reply-to

Content
Sorry for the delay. getrandom_nonblocking_v4.patch LGTM, but I made a major change: if getrandom() fails with EAGAIN, it now always fall back on reading /dev/urandom. I also documented the change in os.urandom() documentation and in Misc/NEWS. I pushed the fix to Python 3.5 and 3.6. Python 2.7 doesn't use getrandom() and so doesn't need the fix. I now consider that the bug is fixed. If you consider that it's important enough to retry calling getrandom() each time os.urandom() is called, please open a new issue with a patch and elaborate your rationale :-)

Content

Sorry for the delay.

getrandom_nonblocking_v4.patch LGTM, but I made a major change: if getrandom() fails with EAGAIN, it now *always* fall back on reading /dev/urandom.

I also documented the change in os.urandom() documentation and in Misc/NEWS.

I pushed the fix to Python 3.5 and 3.6. Python 2.7 doesn't use getrandom() and so doesn't need the fix. I now consider that the bug is fixed.

If you consider that it's important enough to retry calling getrandom() each time os.urandom() is called, please open a new issue with a patch and elaborate your rationale :-)

History
Date	User	Action	Args
2016-06-07 09:39:57	vstinner	set	recipients: + vstinner, lemburg, rhettinger, doko, larry, matejcik, ned.deily, skrah, python-dev, martin.panter, ztane, thomas-petazzoni, Colm Buckley
2016-06-07 09:39:57	vstinner	set	messageid: <1465292397.35.0.254476882747.issue26839@psf.upfronthosting.co.za>
2016-06-07 09:39:57	vstinner	link	issue26839 messages
2016-06-07 09:39:57	vstinner	create