Message269692
| Author | terry.reedy |
|---|---|
| Recipients | markroseman, ned.deily, serhiy.storchaka, terry.reedy |
| Date | 2016-07-01.19:43:09 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1467402189.77.0.971333021216.issue27173@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
Seems to be working correctly now, so I will review the code in detail. I will look into extracting a common get_theme_keys function and editing the long docstring currently attached to CurrentTheme. I want to look at paired functions in configdialog, such as def VarChanged_builtinTheme/Keys to see if there are any unnecessary differences. The hardest thing is adding tests. Correct answers depend on the configuration vales, both default and user overrides. See #24737 for the latter. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2016-07-01 19:43:09 | terry.reedy | set | recipients: + terry.reedy, ned.deily, markroseman, serhiy.storchaka |
| 2016-07-01 19:43:09 | terry.reedy | set | messageid: <1467402189.77.0.971333021216.issue27173@psf.upfronthosting.co.za> |
| 2016-07-01 19:43:09 | terry.reedy | link | issue27173 messages |
| 2016-07-01 19:43:09 | terry.reedy | create | |