Message270828
| Author | Anders.Hovmöller |
|---|---|
| Recipients | Anders.Hovmöller, Arfrever, Eric.Hanchrow, Roman.Evstifeev, SilentGhost, aymeric.augustin, barry, belopolsky, berker.peksag, cvrebert, davydov, deronnax, eric.araujo, flying sheep, jcea, jstasiak, jwilk, karlcow, kirpit, martin.panter, mcepl, mihaic, nagle, pbryan, perey, piotr.dobrogost, r.david.murray, roysmith, vstinner |
| Date | 2016-07-19.14:07:26 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <BA37345A-C09D-4F78-BCA2-F2BB819842DF@killingar.net> |
| In-reply-to | <1468633293.37.0.278743850594.issue15873@psf.upfronthosting.co.za> |
| Content | |
|---|---|
The tests attached to this ticket seem pretty bare. Issues that I can spot directly:
- only tests for datetimes, not times or dates
- only tests for zulu and "-8:00” timezones
- no tests for invalid input (parsing a valid date as a datetime for example)
- only tests for YYYY-MM-DDTHH:MM:SSZ, but ISO8601 supports:
- Naive times
- Timezone information (specified as offsets or as Z for 0 offset)
- Year
- Year-month
- Year-month-date
- Year-week
- Year-week-weekday
- Year-ordinal day
- Hour
- Hour-minute
- Hour-minute
- Hour-minute-second
- Hour-minute-second-microsecond
- All combinations of the three "families" above!
(the above list is a copy paste from my project that implements all ISO8601 that fits into native python: https://github.com/boxed/iso8601 <https://github.com/boxed/iso8601>)
This is a more reasonable test suite: https://github.com/boxed/iso8601/blob/master/iso8601.py#L166 <https://github.com/boxed/iso8601/blob/master/iso8601.py#L166> although it lacks the tests for bogus inputs.
> On 2016-07-16, at 03:41, Alexander Belopolsky <report@bugs.python.org> wrote:
>
>
> Alexander Belopolsky added the comment:
>
> I would very much like to see this ready before the feature cut-off for Python 3.6. Could someone post a summary on python-ideas to get a show of hands on some of the remaining wrinkles?
>
> I would not worry about a C implementation at this point. We can put python implementation in _strptime.py and call it from C as we do for the strptime method.
>
> ----------
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue15873>
> _______________________________________ |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2016-07-19 14:07:26 | Anders.Hovmöller | set | recipients: + Anders.Hovmöller, barry, jcea, roysmith, belopolsky, nagle, vstinner, jwilk, mcepl, eric.araujo, Arfrever, r.david.murray, davydov, cvrebert, karlcow, SilentGhost, perey, flying sheep, mihaic, aymeric.augustin, Roman.Evstifeev, berker.peksag, martin.panter, piotr.dobrogost, kirpit, jstasiak, Eric.Hanchrow, deronnax, pbryan |
| 2016-07-19 14:07:26 | Anders.Hovmöller | link | issue15873 messages |
| 2016-07-19 14:07:26 | Anders.Hovmöller | create | |