Message 273004 - Python tracker

Message273004

Author	martin.panter
Recipients	martin.panter, vstinner
Date	2016-08-18.00:07:11
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1471478831.98.0.28888905347.issue27787@psf.upfronthosting.co.za>
In-reply-to

Content
Yes I agree it would make sense to separate the test_httplib changes from the general change. I thought this task would be a very easy change, and noticed it wasn’t that simple the last minute. I would like to adjust the cleanup call to self.addCleanup(thread.join, float(1)) That should be a better equivalent to what @reap_threads does. Or I can just use @reap_threads directly on test_response_fileno(), if people prefer.

Content

Yes I agree it would make sense to separate the test_httplib changes from the general change. I thought this task would be a very easy change, and noticed it wasn’t that simple the last minute.

I would like to adjust the cleanup call to

self.addCleanup(thread.join, float(1))

That should be a better equivalent to what @reap_threads does. Or I can just use @reap_threads directly on test_response_fileno(), if people prefer.

History
Date	User	Action	Args
2016-08-18 00:07:12	martin.panter	set	recipients: + martin.panter, vstinner
2016-08-18 00:07:11	martin.panter	set	messageid: <1471478831.98.0.28888905347.issue27787@psf.upfronthosting.co.za>
2016-08-18 00:07:11	martin.panter	link	issue27787 messages
2016-08-18 00:07:11	martin.panter	create