Message 273018 - Python tracker

Message273018

Author	christian.heimes
Recipients	Lukasa, christian.heimes, vstinner
Date	2016-08-18.10:49:20
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1471517370.65.0.0596233552062.issue27744@psf.upfronthosting.co.za>
In-reply-to

Content
Thanks for your review, Victor. I have addressed most of your remarks. * algset() is now called sendmsg_afalg(). It behaves more like a specialized version of sendmsg() and can optionally handle an array of iovec. * I had to add another variant of setsockopt that sends NULL, int instead of (char)int, sizeof(int) to get the AEAD GCM tests working. AEAD expects ALG_SET_AEAD_AUTHSIZE as (NULL, taglen). algo.setsockopt(SOL_ALG, ALG_SET_AEAD_AUTHSIZE, (None, taglen)) sends optval=NULL, optlen=taglen. Added tests for AES-CBC decryption, AEAD AES-GCM and DRBG.

Content

Thanks for your review, Victor. I have addressed most of your remarks.

* algset() is now called sendmsg_afalg(). It behaves more like a specialized version of sendmsg() and can optionally handle an array of iovec.

* I had to add another variant of setsockopt that sends NULL, int instead of (char*)int, sizeof(int) to get the AEAD GCM tests working. AEAD expects ALG_SET_AEAD_AUTHSIZE as (NULL, taglen). algo.setsockopt(SOL_ALG, ALG_SET_AEAD_AUTHSIZE, (None, taglen)) sends optval=NULL, optlen=taglen.

* Added tests for AES-CBC decryption, AEAD AES-GCM and DRBG.

History
Date	User	Action	Args
2016-08-18 10:49:30	christian.heimes	set	recipients: + christian.heimes, vstinner, Lukasa
2016-08-18 10:49:30	christian.heimes	set	messageid: <1471517370.65.0.0596233552062.issue27744@psf.upfronthosting.co.za>
2016-08-18 10:49:30	christian.heimes	link	issue27744 messages
2016-08-18 10:49:30	christian.heimes	create