Message289406
| Author | niklasf |
|---|---|
| Recipients | mark.dickinson, niklasf, serhiy.storchaka |
| Date | 2017-03-10.20:09:01 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1489176541.4.0.758981082936.issue29782@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
Thanks for the review. I pushed a change to check if clz can be used (`sizeof(digit) <= sizeof(unsigned int)`). Otherwise use clzl. I believe the latter should be the most common, since unsigned long has 32bits. As you say unsigned long long should never be needed. Btw. mathmodule.c currently duplicates the function: https://github.com/python/cpython/blob/master/Modules/mathmodule.c#L1317. It might be worth factoring it out, but I don't know where to put it. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2017-03-10 20:09:01 | niklasf | set | recipients: + niklasf, mark.dickinson, serhiy.storchaka |
| 2017-03-10 20:09:01 | niklasf | set | messageid: <1489176541.4.0.758981082936.issue29782@psf.upfronthosting.co.za> |
| 2017-03-10 20:09:01 | niklasf | link | issue29782 messages |
| 2017-03-10 20:09:01 | niklasf | create | |