Message291776
| Author | louielu |
|---|---|
| Recipients | louielu, methane, r.david.murray, serhiy.storchaka, xiang.zhang |
| Date | 2017-04-17.03:13:35 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1492398816.26.0.843499412714.issue30040@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
Inada's patch version act different inside `PyObject_SetItem`,
when running this code: 'x = {}; x['a'] = 123'
at PyObject_SetItem,
patch version goes to this line:
>│179 if (m && m->mp_ass_subscript)
│180 return m->mp_ass_subscript(o, key, value);
but original version goes to:
>│182 if (o->ob_type->tp_as_sequence) {
│183 if (PyIndex_Check(key)) {
I think that's why the performance issue came out, still digging why this happened. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2017-04-17 03:13:36 | louielu | set | recipients: + louielu, r.david.murray, methane, serhiy.storchaka, xiang.zhang |
| 2017-04-17 03:13:36 | louielu | set | messageid: <1492398816.26.0.843499412714.issue30040@psf.upfronthosting.co.za> |
| 2017-04-17 03:13:36 | louielu | link | issue30040 messages |
| 2017-04-17 03:13:35 | louielu | create | |