Message292398
| Author | xiang.zhang |
|---|---|
| Recipients | Arfrever, benjamin.peterson, docs@python, martin.panter, r.david.murray, rhettinger, serhiy.storchaka, vstinner, xiang.zhang, zbysz |
| Date | 2017-04-27.04:41:57 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1493268117.33.0.48479665619.issue21071@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
+1 for change bytes to str. But struct.Struct() accepts both bytes and str, maybe in future buffer objects. When it gets a bytes object, converting it to a str looks unnecessary to me, and as OP said, comparison (a theoretical use case) could still fail. Could we just leave what the user passes in? bytes(bytes-like) -> bytes, str -> str. This looks more natural to me. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2017-04-27 04:41:57 | xiang.zhang | set | recipients: + xiang.zhang, rhettinger, vstinner, benjamin.peterson, Arfrever, r.david.murray, zbysz, docs@python, martin.panter, serhiy.storchaka |
| 2017-04-27 04:41:57 | xiang.zhang | set | messageid: <1493268117.33.0.48479665619.issue21071@psf.upfronthosting.co.za> |
| 2017-04-27 04:41:57 | xiang.zhang | link | issue21071 messages |
| 2017-04-27 04:41:57 | xiang.zhang | create | |