Message 299000 - Python tracker

Message299000

Author	jmsdvl
Recipients	daves, jmsdvl, ncoghlan, serhiy.storchaka
Date	2017-07-24.17:29:42
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1500917382.9.2.68489037173e-05.issue31014@psf.upfronthosting.co.za>
In-reply-to

Content
Ok I understand what you mean. I think the only conditions for test failure are (A) $BROWSER is set and (B) $BROWSER is set to an actual executable that should be caught by ``register_standard_browsers`` prior to execution reaching the last if clause of ``register_standard_browsers`` (``if 'BROWSER' in os.environ:``) - those two conditions should be sufficient for execution to reach the offending line of code. I'll see if I can cook up a test for that. I think the right way to do this is to monkeypatch ``os.environ`` and ``shutil.which``, am I right?

Content

Ok I understand what you mean.

I think the only conditions for test failure are (A) $BROWSER is set and (B) $BROWSER is set to an actual executable that should be caught by ``register_standard_browsers`` prior to execution reaching the last if clause of ``register_standard_browsers`` (``if 'BROWSER' in os.environ:``) - those two conditions should be sufficient for execution to reach the offending line of code.

I'll see if I can cook up a test for that.  I think the right way to do this is to monkeypatch ``os.environ`` and ``shutil.which``, am I right?

History
Date	User	Action	Args
2017-07-24 17:29:42	jmsdvl	set	recipients: + jmsdvl, ncoghlan, serhiy.storchaka, daves
2017-07-24 17:29:42	jmsdvl	set	messageid: <1500917382.9.2.68489037173e-05.issue31014@psf.upfronthosting.co.za>
2017-07-24 17:29:42	jmsdvl	link	issue31014 messages
2017-07-24 17:29:42	jmsdvl	create