Message 301148 - Python tracker

Message301148

Author	berker.peksag
Recipients	berker.peksag, gvx, rhettinger
Date	2017-09-01.19:32:00
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1504294320.95.0.310085106571.issue31325@psf.upfronthosting.co.za>
In-reply-to

Content
Good catch and thank you for turning the bug report in the HN thread to a pull request! I agree with all of Raymond's comments. I have two more comments: * Please follow our commit style at https://devguide.python.org/committing/#commit-messages * We need a NEWS entry. You can find details at https://devguide.python.org/committing/#what-s-new-and-news-entries (we don't need to add an entry in Doc/whatsnew/ so you can safely ignore it)

Content

Good catch and thank you for turning the bug report in the HN thread to a pull request! I agree with all of Raymond's comments.

I have two more comments:

* Please follow our commit style at https://devguide.python.org/committing/#commit-messages
* We need a NEWS entry. You can find details at https://devguide.python.org/committing/#what-s-new-and-news-entries (we don't need to add an entry in Doc/whatsnew/ so you can safely ignore it)

History
Date	User	Action	Args
2017-09-01 19:32:00	berker.peksag	set	recipients: + berker.peksag, rhettinger, gvx
2017-09-01 19:32:00	berker.peksag	set	messageid: <1504294320.95.0.310085106571.issue31325@psf.upfronthosting.co.za>
2017-09-01 19:32:00	berker.peksag	link	issue31325 messages
2017-09-01 19:32:00	berker.peksag	create