Message 303695 - Python tracker

Message303695

Author	barry
Recipients	barry, ezio.melotti, methane, mrabarnett, serhiy.storchaka
Date	2017-10-04.14:07:32
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<FF0DCCDD-F18B-48B4-AA7A-396DE742068F@python.org>
In-reply-to	<1507089113.55.0.213398074469.issue31677@psf.upfronthosting.co.za>

Content
On Oct 3, 2017, at 23:51, INADA Naoki <report@bugs.python.org> wrote: >> It's better to keep the re.IGNORECASE since the RFC also says: >> >> Both 'encoding' and 'charset' names are case-independent. Thus the >> charset name "ISO-8859-1" is equivalent to "iso-8859-1", and the >> encoding named "Q" may be spelled either "Q" or "q". > > I'm sorry, I've committed before reading this. > But I think it's not problem, because re.IGNORECASE doesn't affect to > "(?P<charset>[^?]*?)" pattern. I think you’re change is fine, no need to revert or modify it.

Content

On Oct 3, 2017, at 23:51, INADA Naoki <report@bugs.python.org> wrote:
>> It's better to keep the re.IGNORECASE since the RFC also says:
>> 
>>  Both 'encoding' and 'charset' names are case-independent.  Thus the
>>  charset name "ISO-8859-1" is equivalent to "iso-8859-1", and the
>>  encoding named "Q" may be spelled either "Q" or "q".
> 
> I'm sorry, I've committed before reading this.
> But I think it's not problem, because re.IGNORECASE doesn't affect to
> "(?P<charset>[^?]*?)" pattern.

I think you’re change is fine, no need to revert or modify it.

History
Date	User	Action	Args
2017-10-04 14:07:33	barry	set	recipients: + barry, ezio.melotti, mrabarnett, methane, serhiy.storchaka
2017-10-04 14:07:33	barry	link	issue31677 messages
2017-10-04 14:07:32	barry	create