Message 306133 - Python tracker

Message306133

Author	Phaqui
Recipients	Phaqui, niki.spahiev, rhettinger, vstinner
Date	2017-11-12.23:05:19
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1510527919.28.0.213398074469.issue31956@psf.upfronthosting.co.za>
In-reply-to

Content
I decided to work on this, and I would like some review, as this would be my second contribution to cpython. Also, a general question: As I defined the start and end arguments Py_ssize_t, bigger indexes (more negative or more positive) than what can fit in Py_ssize_t will trigger an overflow error. This should be OK, though, as other functions with index arguments has them as Py_ssize_t - and getarrayitem() itself accepts a Py_ssize_t. Or?

Content

I decided to work on this, and I would like some review, as this would be my second contribution to cpython. Also, a general question:

As I defined the start and end arguments Py_ssize_t, bigger indexes (more negative or more positive) than what can fit in Py_ssize_t will trigger an overflow error. This should be OK, though, as other functions with index arguments has them as Py_ssize_t - and getarrayitem() itself accepts a Py_ssize_t. Or?

History
Date	User	Action	Args
2017-11-12 23:05:19	Phaqui	set	recipients: + Phaqui, rhettinger, vstinner, niki.spahiev
2017-11-12 23:05:19	Phaqui	set	messageid: <1510527919.28.0.213398074469.issue31956@psf.upfronthosting.co.za>
2017-11-12 23:05:19	Phaqui	link	issue31956 messages
2017-11-12 23:05:19	Phaqui	create