Message 309163 - Python tracker

Message309163

Author	pitrou
Recipients	Demur Rumed, Mark.Shannon, benjamin.peterson, christian.heimes, mark.dickinson, nascheme, ncoghlan, pitrou, rhettinger, serhiy.storchaka, trent
Date	2017-12-29.08:23:24
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<a2b39624-16c9-0c42-328e-3e0dbc2ce78e@free.fr>
In-reply-to	<1514525205.86.0.213398074469.issue17611@psf.upfronthosting.co.za>

Content
Le 29/12/2017 à 06:26, Neil Schemenauer a écrit : > > I wonder if I should drop PR 4682. My main criterion (apart from performance issues which don't seem to exist) for choosing between the two PRs would be implementation complexity. I find Serhiy's PR pleasantly uncomplicated (it even simplifies the code in frameobject.c). Your PR seems to add more complexity, so I would be inclined to choose Serhiy's PR.

Content

Le 29/12/2017 à 06:26, Neil Schemenauer a écrit :
> 
> I wonder if I should drop PR 4682.

My main criterion (apart from performance issues which don't seem to
exist) for choosing between the two PRs would be implementation
complexity.  I find Serhiy's PR pleasantly uncomplicated (it even
*simplifies* the code in frameobject.c).

Your PR seems to add more complexity, so I would be inclined to choose
Serhiy's PR.

History
Date	User	Action	Args
2017-12-29 08:23:24	pitrou	set	recipients: + pitrou, nascheme, rhettinger, mark.dickinson, ncoghlan, christian.heimes, benjamin.peterson, trent, Mark.Shannon, serhiy.storchaka, Demur Rumed
2017-12-29 08:23:24	pitrou	link	issue17611 messages
2017-12-29 08:23:24	pitrou	create