Message 310660 - Python tracker

Message310660

Author	chason.chaffin
Recipients	Kenny Trytek, chason.chaffin, steven.daprano
Date	2018-01-25.07:25:23
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1516865123.61.0.467229070634.issue32657@psf.upfronthosting.co.za>
In-reply-to

Content
Hi Steven, I have nothing to do with the original submitter but this bug did catch my eye. Does using mutable variables in the SMTP library serve a purpose? Looking through the code, I wasn't able to spot anything obvious, and I did spot a place with a potential bug: https://github.com/python/cpython/blob/master/Lib/smtplib.py#L960 Here mail_options is mutated in the case of a non-ASCII email address. Subsequent calls to send_message, even to a different SMTP server (if I'm not mistaken) would also send these headers along.

Content

Hi Steven,

I have nothing to do with the original submitter but this bug did catch my eye. Does using mutable variables in the SMTP library serve a purpose? Looking through the code, I wasn't able to spot anything obvious, and I did spot a place with a potential bug:

https://github.com/python/cpython/blob/master/Lib/smtplib.py#L960

Here mail_options is mutated in the case of a non-ASCII email address. Subsequent calls to send_message, even to a different SMTP server (if I'm not mistaken) would also send these headers along.

History
Date	User	Action	Args
2018-01-25 07:25:23	chason.chaffin	set	recipients: + chason.chaffin, steven.daprano, Kenny Trytek
2018-01-25 07:25:23	chason.chaffin	set	messageid: <1516865123.61.0.467229070634.issue32657@psf.upfronthosting.co.za>
2018-01-25 07:25:23	chason.chaffin	link	issue32657 messages
2018-01-25 07:25:23	chason.chaffin	create