Message316354
| Author | serhiy.storchaka |
|---|---|
| Recipients | eric.snow, serhiy.storchaka, siddhesh |
| Date | 2018-05-10.10:17:56 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1525947476.64.0.682650639539.issue33454@psf.upfronthosting.co.za> |
| In-reply-to |
| Content | |
|---|---|
The C function that implements _xxsubinterpreters.channel_close() is defined with the signature
PyObject *channel_close(PyObject *self, PyObject *args, PyObject *kwds)
which corresponds the method convention METH_VARARGS | METH_KEYWORDS, but is used with the incompatible method convention METH_VARARGS. Either the signature or flags are not correct.
Actually it can use just METH_O. The proposed PR changes both signature and flags and simplifies the implementation.
The bug was found thanks to gcc 8 emitting a warning for invalid function cast (it also emits a lot of false alarms). See also issue33012. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2018-05-10 10:17:56 | serhiy.storchaka | set | recipients: + serhiy.storchaka, eric.snow, siddhesh |
| 2018-05-10 10:17:56 | serhiy.storchaka | set | messageid: <1525947476.64.0.682650639539.issue33454@psf.upfronthosting.co.za> |
| 2018-05-10 10:17:56 | serhiy.storchaka | link | issue33454 messages |
| 2018-05-10 10:17:56 | serhiy.storchaka | create | |