Message 321975 - Python tracker

Message321975

Author	bbayles
Recipients	bbayles, skip.montanaro, xiang.zhang, xtreak
Date	2018-07-20.03:12:46
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1532056367.48.0.56676864532.issue34132@psf.upfronthosting.co.za>
In-reply-to

Content
I took a shot at this, but closed my PR when I found that it introduced a different regression. After playing with it for a bit, I think that this commit [1] is a bit problematic because it uses lexer.instream.readline(), which can make the line number in lexer.lineno incorrect. I may take another look if I have time, but someone else is free to tackle this. [1] https://github.com/python/cpython/commit/1df0f214a9fdb4dde7506576b144cf6a7fd01b65#diff-e6896f6d68ca3fd8094a933533f8b2ed

Content

I took a shot at this, but closed my PR when I found that it introduced a different regression.

After playing with it for a bit, I think that this commit [1] is a bit problematic because it uses lexer.instream.readline(), which can make the line number in lexer.lineno incorrect.

I may take another look if I have time, but someone else is free to tackle this.

[1] https://github.com/python/cpython/commit/1df0f214a9fdb4dde7506576b144cf6a7fd01b65#diff-e6896f6d68ca3fd8094a933533f8b2ed

History
Date	User	Action	Args
2018-07-20 03:12:47	bbayles	set	recipients: + bbayles, skip.montanaro, xiang.zhang, xtreak
2018-07-20 03:12:47	bbayles	set	messageid: <1532056367.48.0.56676864532.issue34132@psf.upfronthosting.co.za>
2018-07-20 03:12:47	bbayles	link	issue34132 messages
2018-07-20 03:12:46	bbayles	create