Message 322559 - Python tracker

Message322559

Author	petr.viktorin
Recipients	petr.viktorin, vandyswa
Date	2018-07-28.13:18:32
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1532783912.34.0.56676864532.issue34113@psf.upfronthosting.co.za>
In-reply-to

Content
The problem here is that tracing for STACKADJ prints out the top of the stack after adjustment. This is OK for growing the stack, but not for shrinking it (e.g. calling STACKADJ(-3) pops off three things at once, which can leave TOP undefined when it's printed out). On the EuroPython sprints, I recommended splitting STACKADJ into STACKADJ_GROW and STACKADJ_SHRINK, since the printing behavior should be different. This is performance-critical code; it needs to be reviewed carefully.

Content

The problem here is that tracing for STACKADJ prints out the top of the stack *after* adjustment. This is OK for growing the stack, but not for shrinking it (e.g. calling STACKADJ(-3) pops off three things at once, which can leave TOP undefined when it's printed out).

On the EuroPython sprints, I recommended splitting STACKADJ into STACKADJ_GROW and STACKADJ_SHRINK, since the printing behavior should be different.
This is performance-critical code; it needs to be reviewed carefully.

History
Date	User	Action	Args
2018-07-28 13:18:32	petr.viktorin	set	recipients: + petr.viktorin, vandyswa
2018-07-28 13:18:32	petr.viktorin	set	messageid: <1532783912.34.0.56676864532.issue34113@psf.upfronthosting.co.za>
2018-07-28 13:18:32	petr.viktorin	link	issue34113 messages
2018-07-28 13:18:32	petr.viktorin	create