Message 328882 - Python tracker

Message328882

Author	ammar2
Recipients	ammar2, gregory.p.smith, meador.inge, pablogsal, taleinat, terry.reedy
Date	2018-10-30.00:56:47
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1540861007.74.0.788709270274.issue35107@psf.upfronthosting.co.za>
In-reply-to

Content
Actually nevermind, disregard that, I was just testing it wrong. I think the simplest fix here is to add '#' to the list of characters here so we don't double insert newlines for comments: https://github.com/python/cpython/blob/b83d917fafd87e4130f9c7d5209ad2debc7219cd/Lib/tokenize.py#L659 And a test for round tripping a file ending with a comment but no newline will allow that particular branch to be tested. I'll make a PR this week if no one else gets to it.

Content

Actually nevermind, disregard that, I was just testing it wrong. I think the simplest fix here is to add '#' to the list of characters here so we don't double insert newlines for comments: https://github.com/python/cpython/blob/b83d917fafd87e4130f9c7d5209ad2debc7219cd/Lib/tokenize.py#L659

And a test for round tripping a file ending with a comment but no newline will allow that particular branch to be tested.

I'll make a PR this week if no one else gets to it.

History
Date	User	Action	Args
2018-10-30 00:56:48	ammar2	set	recipients: + ammar2, terry.reedy, gregory.p.smith, taleinat, meador.inge, pablogsal
2018-10-30 00:56:47	ammar2	set	messageid: <1540861007.74.0.788709270274.issue35107@psf.upfronthosting.co.za>
2018-10-30 00:56:47	ammar2	link	issue35107 messages
2018-10-30 00:56:47	ammar2	create