Message 329037 - Python tracker

Message329037

Author	vstinner
Recipients	eric.snow, vstinner
Date	2018-11-01.02:25:24
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1541039124.71.0.788709270274.issue35081@psf.upfronthosting.co.za>
In-reply-to

Content
> bpo-35081: And pycore_lifecycle.h and pycore_pathconfig.h (GH-10273) I tried to add the Py_BUILD_CORE guard in pycore_pathconfig.h: +#ifndef Py_BUILD_CORE +# error "Py_BUILD_CORE must be defined to include this header" +#endif But it breaks the compilation of _testcapimodule.c: get_coreconfig() uses _Py_wstrlist_as_pylist(), and _Py_wstrlist_as_pylist() is defined in pycore_pathconfig.h. IMHO _testcapi should be compiled with Py_BUILD_CORE defined. I wrote PR 10274 but then _testcapi fails because of datetime.h: this bug should be fixed by PR 10238.

Content

> bpo-35081: And pycore_lifecycle.h and pycore_pathconfig.h (GH-10273)

I tried to add the Py_BUILD_CORE guard in pycore_pathconfig.h:

+#ifndef Py_BUILD_CORE
+#  error "Py_BUILD_CORE must be defined to include this header"
+#endif

But it breaks the compilation of _testcapimodule.c: get_coreconfig() uses _Py_wstrlist_as_pylist(), and _Py_wstrlist_as_pylist() is defined in pycore_pathconfig.h.

IMHO _testcapi should be compiled with Py_BUILD_CORE defined. I wrote PR 10274 but then _testcapi fails because of datetime.h: this bug should be fixed by PR 10238.

History
Date	User	Action	Args
2018-11-01 02:25:24	vstinner	set	recipients: + vstinner, eric.snow
2018-11-01 02:25:24	vstinner	set	messageid: <1541039124.71.0.788709270274.issue35081@psf.upfronthosting.co.za>
2018-11-01 02:25:24	vstinner	link	issue35081 messages
2018-11-01 02:25:24	vstinner	create