Message 332284 - Python tracker

Message332284

Author	kulikjak
Recipients	kulikjak
Date	2018-12-21.10:08:03
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1545386883.42.0.788709270274.issue35550@psf.upfronthosting.co.za>
In-reply-to

Content
Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Our recent Solaris python build ended up skipping these sections resulting in some obvious problems. Defines should check for __sun instead. (link: http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system#Solaris)

Content

Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Our recent Solaris python build ended up skipping these sections resulting in some obvious problems.

Defines should check for __sun instead.

(link: http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system#Solaris)

History
Date	User	Action	Args
2018-12-21 10:08:03	kulikjak	set	recipients: + kulikjak
2018-12-21 10:08:03	kulikjak	set	messageid: <1545386883.42.0.788709270274.issue35550@psf.upfronthosting.co.za>
2018-12-21 10:08:03	kulikjak	link	issue35550 messages
2018-12-21 10:08:03	kulikjak	create