Message 333093 - Python tracker

Message333093

Author	vajrasky
Recipients	antonymayi, drpotato, jcea, lars.gustaebel, martin.panter, serhiy.storchaka, vajrasky, vstinner
Date	2019-01-06.08:57:32
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1546765052.24.0.684265039179.issue19974@roundup.psfhosted.org>
In-reply-to

Content
Martin Panter, I have modernized the patch. About your suggestion: 1. "import errno" -> Yes, this is unnecessary. I have removed it. 2. Use os.path.lexists instead of os.path.islink for broken symlink -> The thing is os.path.islink returns True also for broken symlink. I could not find a case where these methods return different result.

Content

Martin Panter,

I have modernized the patch.

About your suggestion:
1. "import errno" -> Yes, this is unnecessary. I have removed it.
2. Use os.path.lexists instead of os.path.islink for broken symlink -> The thing is os.path.islink returns True also for broken symlink. I could not find a case where these methods return different result.

History
Date	User	Action	Args
2019-01-06 08:57:33	vajrasky	set	recipients: + vajrasky, jcea, lars.gustaebel, vstinner, martin.panter, serhiy.storchaka, antonymayi, drpotato
2019-01-06 08:57:32	vajrasky	set	messageid: <1546765052.24.0.684265039179.issue19974@roundup.psfhosted.org>
2019-01-06 08:57:32	vajrasky	link	issue19974 messages
2019-01-06 08:57:32	vajrasky	create