Message 335027 - Python tracker

Message335027

Author	eric.snow
Recipients	alexandre.vassalotti, brett.cannon, eric.snow, ncoghlan, pitrou, tjb900
Date	2019-02-07.16:39:48
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1549557588.84.0.36695846072.issue34572@roundup.psfhosted.org>
In-reply-to

Content
Perhaps PyImport_GetModule() should aquire-release the module's lock before the lookup? This would effectively be a call to _lock_unlock_module() in importlib._bootstrap. The alternative is to encourage using PyImport_Import() instead, like the PR has done. In the case the docs for PyImport_GetModule() should make it clear that it is guaranteed that the module is fully imported yet (and recommend using PyImport_Import() for the guarantee). Either way there should be a new issue for the more general change (and it should reference this issue).

Content

Perhaps PyImport_GetModule() should aquire-release the module's lock before the lookup?  This would effectively be a call to _lock_unlock_module() in importlib._bootstrap.

The alternative is to encourage using PyImport_Import() instead, like the PR has done.  In the case the docs for PyImport_GetModule() should make it clear that it is guaranteed that the module is fully imported yet (and recommend using PyImport_Import() for the guarantee).

Either way there should be a new issue for the more general change (and it should reference this issue).

History
Date	User	Action	Args
2019-02-07 16:39:50	eric.snow	set	recipients: + eric.snow, brett.cannon, ncoghlan, pitrou, alexandre.vassalotti, tjb900
2019-02-07 16:39:48	eric.snow	set	messageid: <1549557588.84.0.36695846072.issue34572@roundup.psfhosted.org>
2019-02-07 16:39:48	eric.snow	link	issue34572 messages
2019-02-07 16:39:48	eric.snow	create