Message 335830 - Python tracker

Message335830

Author	remi.lapeyre
Recipients	Adeokkuw, lukasz.langa, remi.lapeyre
Date	2019-02-18.13:08:32
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1550495312.75.0.551456795329.issue35954@roundup.psfhosted.org>
In-reply-to

Content
> Btw: The name "read_dict" [1] as well as its docstring say exactly the opposite of what it does. It acts as a "save_dict". Maybe that can be fixed on the go ... The name `read_dict` is correct, it reads from the dict given as parameter and changing the name would break existing code. I opened a new PR with the change to convert keys to strings in __getitem__, I did not wrap `key = str(key)` in a try-except as it's not done in read_dict(). This way both __getitem__ and read_dict() will fail the same way.

Content

> Btw: The name "read_dict" [1] as well as its docstring say exactly the opposite of what it does. It acts as a "save_dict". Maybe that can be fixed on the go ...


The name `read_dict` is correct, it reads from the dict given as parameter and changing the name would break existing code.

I opened a new PR with the change to convert keys to strings in __getitem__, I did not wrap `key = str(key)` in a try-except as it's not done in read_dict(). This way both __getitem__ and read_dict() will fail the same way.

History
Date	User	Action	Args
2019-02-18 13:08:32	remi.lapeyre	set	recipients: + remi.lapeyre, lukasz.langa, Adeokkuw
2019-02-18 13:08:32	remi.lapeyre	set	messageid: <1550495312.75.0.551456795329.issue35954@roundup.psfhosted.org>
2019-02-18 13:08:32	remi.lapeyre	link	issue35954 messages
2019-02-18 13:08:32	remi.lapeyre	create