Message336389
| Author | xtreak |
|---|---|
| Recipients | cjw296, jaraco, mariocj89, michael.foord, xtreak |
| Date | 2019-02-23.16:49:05 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1550940545.87.0.641264801498.issue35512@roundup.psfhosted.org> |
| In-reply-to |
| Content | |
|---|---|
Thanks Mario for the details. I had almost the same patch while writing msg336300 :) There were no test case failures except that I had resolved it in the constructor storing the string representation as a separate variable and also while calling the function which could be avoided as per your approach to just store the string and resolve once during function call. I think this is a good way to do this. Are you planning to create a PR or shall I go ahead with this? |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-02-23 16:49:05 | xtreak | set | recipients: + xtreak, jaraco, cjw296, michael.foord, mariocj89 |
| 2019-02-23 16:49:05 | xtreak | set | messageid: <1550940545.87.0.641264801498.issue35512@roundup.psfhosted.org> |
| 2019-02-23 16:49:05 | xtreak | link | issue35512 messages |
| 2019-02-23 16:49:05 | xtreak | create | |