Message 336394 - Python tracker

Message336394

Author	xxxxxxx
Recipients	giampaolo.rodola, xxxxxxx
Date	2019-02-23.18:02:42
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1550944962.71.0.582214075307.issue35648@roundup.psfhosted.org>
In-reply-to

Content
You are right about the bug. The funny thing is, I never saw it. The problem I see is another. The use_srcentry variable in the _copytree function is set by determining if the copy_function is the function copy2 or copy. If so the srcentry is passed to the copy_function. If the user passes a custom copy_function to copytree, this function will ever become only the srcname and not the srcentry. To summarize it: The integrated copy_functions get the srcentry and custom copy_functions get the srcname. But what is if the custom copy_function is a edited copy2 function or needs the srcentry? In order to fix this was my idea to have a parameter to control if the custom copy_function get the srcentry or a srcname. Please write me if there is anything misconception in my thoughts or other objections?

Content

You are right about the bug. The funny thing is, I never saw it.

The problem I see is another.
The use_srcentry variable in the _copytree function is set by determining if the copy_function is the function copy2 or copy. If so the srcentry is passed to the copy_function. If the user passes a custom copy_function to copytree, this function will ever become only the srcname and not the srcentry. To summarize it: The integrated copy_functions get the srcentry and custom copy_functions get the srcname.
But what is if the custom copy_function is a edited copy2 function or needs the srcentry? In order to fix this was my idea to have a parameter to control if the custom copy_function get the srcentry or a srcname.
Please write me if there is anything misconception in my thoughts or other objections?

History
Date	User	Action	Args
2019-02-23 18:02:42	xxxxxxx	set	recipients: + xxxxxxx, giampaolo.rodola
2019-02-23 18:02:42	xxxxxxx	set	messageid: <1550944962.71.0.582214075307.issue35648@roundup.psfhosted.org>
2019-02-23 18:02:42	xxxxxxx	link	issue35648 messages
2019-02-23 18:02:42	xxxxxxx	create