Message 336647 - Python tracker

Message336647

Author	vstinner
Recipients	eric.snow, pablogsal, rhettinger, serhiy.storchaka, vstinner
Date	2019-02-26.11:21:07
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1551180067.73.0.736815902375.issue35459@roundup.psfhosted.org>
In-reply-to

Content
> It seems like the change introduced a regression: bpo-36110. While the test has been fixed, IMHO we need to better document this subtle behavior change since it can be surprising. The test failed because PyObject_GetAttr() no longer ignores exceptions when getting the attribute from the type dictionary. It's a significant change compared to Python 3.7. Right now, the change has not even a NEWS entry, whereas it's a backward incompatible change! Don't get my wrong: the change is correct, we don't want to ignore arbitrary exceptions, it's just a matter of documentation.

Content

> It seems like the change introduced a regression: bpo-36110.

While the test has been fixed, IMHO we need to better document this subtle behavior change since it can be surprising.

The test failed because PyObject_GetAttr() no longer ignores exceptions when getting the attribute from the type dictionary. It's a significant change compared to Python 3.7.

Right now, the change has not even a NEWS entry, whereas it's a backward incompatible change!

Don't get my wrong: the change is correct, we don't want to ignore arbitrary exceptions, it's just a matter of documentation.

History
Date	User	Action	Args
2019-02-26 11:21:07	vstinner	set	recipients: + vstinner, rhettinger, eric.snow, serhiy.storchaka, pablogsal
2019-02-26 11:21:07	vstinner	set	messageid: <1551180067.73.0.736815902375.issue35459@roundup.psfhosted.org>
2019-02-26 11:21:07	vstinner	link	issue35459 messages
2019-02-26 11:21:07	vstinner	create