Message336841
| Author | vstinner |
|---|---|
| Recipients | vstinner |
| Date | 2019-02-28.15:37:33 |
| SpamBayes Score | -1.0 |
| Marked as misclassified | Yes |
| Message-id | <1551368254.14.0.622163548129.issue36146@roundup.psfhosted.org> |
| In-reply-to |
| Content | |
|---|---|
The detect_modules() method of setup.py became longer and longer over the years. It is now 1128 lines long. It's way too long: it becomes very hard to track the lifetime of a variable and many variables are overriden on purpose or not. Shorter functions help to track the lifetime of variables, ease review and reduce the number of bugs. |
|
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-02-28 15:37:34 | vstinner | set | recipients: + vstinner |
| 2019-02-28 15:37:34 | vstinner | set | messageid: <1551368254.14.0.622163548129.issue36146@roundup.psfhosted.org> |
| 2019-02-28 15:37:34 | vstinner | link | issue36146 messages |
| 2019-02-28 15:37:33 | vstinner | create | |