Message 336884 - Python tracker

Message336884

Author	terry.reedy
Recipients	cheryl.sabella, terry.reedy
Date	2019-03-01.01:50:51
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1551405051.74.0.595684835271.issue36152@roundup.psfhosted.org>
In-reply-to

Content
Thanks for digging up the history. I would have approved without, but feel better with. Using the colorizer close method to close a window seemed flakey to me, and it seems someone else thought the same long ago. I suspect the machinery was left to avoid breaking external uses. PEP 434 changed this avoidance being necessary. (I am sure I have seen a SO answer with percolator + colorizer, as in turtledemo.) IDLE has had a too many shutdown bugs and still has some. Not adding one was my main concern when reviewing.

Content

Thanks for digging up the history.  I would have approved without, but feel better with.  Using the colorizer close method to close a window seemed flakey to me, and it seems someone else thought the same long ago.  I suspect the machinery was left to avoid breaking external uses.  PEP 434 changed this avoidance being *necessary*.  (I am sure I have seen a SO answer with percolator + colorizer, as in turtledemo.)

IDLE has had a too many shutdown bugs and still has some.  Not adding one was my main concern when reviewing.

History
Date	User	Action	Args
2019-03-01 01:50:51	terry.reedy	set	recipients: + terry.reedy, cheryl.sabella
2019-03-01 01:50:51	terry.reedy	set	messageid: <1551405051.74.0.595684835271.issue36152@roundup.psfhosted.org>
2019-03-01 01:50:51	terry.reedy	link	issue36152 messages
2019-03-01 01:50:51	terry.reedy	create